Allow ValueTableLineParser to handle the case of (number " ") without… #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… breaking the quotes onto multiple lines and then failing to build a dictionary after.
|
Hi @Werewolfkiss,
Feel free to review and comment our PR. The fix will be available in the next release. Thanks again, |
|
I had to revert the merge, a test was failing |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… breaking the quotes onto multiple lines and then failing to build a dictionary after.
Before this change
72 "H" 33 "!" 32 " " ;
Gets broken up into
72 "H"
33 "!"
32 "
"
Instead of what it should be:
72 "H"
33 "!"
32 " "